rust: doctests: Mark generated rustdoc kunit tests extern "C" #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated rustdoc tests were marked no_mangle, but not extern "C". Since these are called from C by KUnit, they should use the C ABI. Signed-off-by: David Gow <davidgow@google.com>
bjorn3
approved these changes
Feb 16, 2023
|
Thanks David!
Yeah, that is fine. We could run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated rustdoc tests were marked no_mangle, but not extern "C". Since these are called from C by KUnit, they should use the C ABI.
This is a follow up to #967 and #966.
I'm away on a different computer than normal, so it's possible I've missed something: rustfmt passed on the
rustdoc_test_gen.rsfile itself (since we're just changing the string), but the generateddoctests_kernel_generated.rshas lots of formatting issues. I elected not to try to fix those (they probably depend on the length of the test name), and quite a few predate this patch.